Move chrome_version_info target into chrome_common.

Move chrome_version_info target into chrome_common.

The source files live in chrome/common, and they're there because
we need to get at version infomation all over the product (not
just from the exe, like the gyp files are currently written).

This refactoring is necessary for a follow-up change.

TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57084

[Evan Martin, 2010-08-20 19:39:53]

The complexity here is due to the nacl stuff (otherwise I'd just put everything
in chrome/common), so I think you're the right reviewer.  Let me know what you
think.

http://codereview.chromium.org/3113026/diff/1/2
File chrome/chrome_browser.gypi (left):

http://codereview.chromium.org/3113026/diff/1/2#oldcode17
chrome/chrome_browser.gypi:17: 'chrome_version_info',
This is no longer necessary, because it's part of common now.

[gregoryd, 2010-08-20 22:03:28]

I am going to try the change on my machine

http://codereview.chromium.org/3113026/diff/1/3
File chrome/chrome_common.gypi (right):

http://codereview.chromium.org/3113026/diff/1/3#newcode468
chrome/chrome_common.gypi:468: 'chrome_version_info',
Since chrome_version_info generates a library from a cc file, it must have a
win64-specific target. common_nacl_win64 is a 64-bit target and cannot link with
the 32-bit chrome_version_info. I am puzzled by the fact that the trybot
succeeded.

[gregoryd, 2010-08-20 23:20:04]

LGTM once the unnecessary line is removed.

http://codereview.chromium.org/3113026/diff/1/3
File chrome/chrome_common.gypi (right):

http://codereview.chromium.org/3113026/diff/1/3#newcode468
chrome/chrome_common.gypi:468: 'chrome_version_info',
I think the explanation is that it links fine also without this line. Please
remove it.

[Lei Zhang, 2010-08-23 19:01:52]

On 2010/08/20 19:39:53, Evan Martin wrote:
> The complexity here is due to the nacl stuff (otherwise I'd just put
everything
> in chrome/common), so I think you're the right reviewer.  Let me know what you
> think.
> 
> http://codereview.chromium.org/3113026/diff/1/2
> File chrome/chrome_browser.gypi (left):
> 
> http://codereview.chromium.org/3113026/diff/1/2#oldcode17
> chrome/chrome_browser.gypi:17: 'chrome_version_info',
> This is no longer necessary, because it's part of common now.

Thanks for doing this. I moved the files into commons but forgot this bit.