Move chrome_version_info target into chrome_common.

chrome/chrome_common.gypi

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'target_defaults': {
     'variables': {
       'chrome_common_target': 0,
     },
     'target_conditions': [
@@ skipping 104 matching lines @@
           'common/time_format.cc',
           'common/time_format.h',
           'common/win_safe_util.cc',
           'common/win_safe_util.h',
         ],
       }],
     ],
   },
   'targets': [
     {
+      'target_name': 'chrome_version_info',
+      'type': '<(library)',
+      'sources': [
+        'common/chrome_version_info.cc',
+        'common/chrome_version_info.h',
+      ],
+      'include_dirs': [
+        '<(DEPTH)',
+      ],
+      'conditions': [
+        [ 'OS == "linux" or OS == "freebsd" or OS == "openbsd" or OS == "solaris"', {
+          'include_dirs': [
+            '<(SHARED_INTERMEDIATE_DIR)',
+          ],
+          'actions': [
+            {
+              'action_name': 'posix_version',
+              'variables': {
+                'lastchange_path':
+                  '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE',
+                'version_py_path': 'tools/build/version.py',
+                'version_path': 'VERSION',
+                'template_input_path': 'common/chrome_version_info_posix.h.version',
+              },
+              'conditions': [
+                [ 'branding == "Chrome"', {
+                  'variables': {
+                     'branding_path':
+                       'app/theme/google_chrome/BRANDING',
+                  },
+                }, { # else branding!="Chrome"
+                  'variables': {
+                     'branding_path':
+                       'app/theme/chromium/BRANDING',
+                  },
+                }],
+              ],
+              'inputs': [
+                '<(template_input_path)',
+                '<(version_path)',
+                '<(branding_path)',
+                '<(lastchange_path)',
+              ],
+              'outputs': [
+                '<(SHARED_INTERMEDIATE_DIR)/chrome/common/chrome_version_info_posix.h',
+              ],
+              'action': [
+                'python',
+                '<(version_py_path)',
+                '-f', '<(version_path)',
+                '-f', '<(branding_path)',
+                '-f', '<(lastchange_path)',
+                '<(template_input_path)',
+                '<@(_outputs)',
+              ],
+              'message': 'Generating version information',
+            },
+          ],
+        }],
+      ]
+    },
+    {
       'target_name': 'common',
       'type': '<(library)',
       'msvs_guid': '899F1280-3441-4D1F-BA04-CCD6208D9146',
       'variables': {
         'chrome_common_target': 1,
       },
       # TODO(gregoryd): This could be shared with the 64-bit target, but
       # it does not work due to a gyp issue.
       'direct_dependent_settings': {
         'include_dirs': [
           '..',
         ],
       },
       'dependencies': [
         # TODO(gregoryd): chrome_resources and chrome_strings could be
         #  shared with the 64-bit target, but it does not work due to a gyp
         # issue.
         'chrome_resources',
         'chrome_strings',
         'common_constants',
         'common_net',
+        'chrome_version_info',
         'default_plugin/default_plugin.gyp:default_plugin',
         'theme_resources',
         '../app/app.gyp:app_base',
         '../app/app.gyp:app_resources',
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
         '../build/temp_gyp/googleurl.gyp:googleurl',
         '../ipc/ipc.gyp:ipc',
         '../net/net.gyp:net',
         '../printing/printing.gyp:printing',
@@ skipping 239 matching lines @@
           'msvs_guid': '3AB5C5E9-470C-419B-A0AE-C7381FB632FA',
           'variables': {
             'chrome_common_target': 1,
           },
           'dependencies': [
             # TODO(gregoryd): chrome_resources and chrome_strings could be
             #  shared with the 32-bit target, but it does not work due to a gyp
             # issue.
             'chrome_resources',
             'chrome_strings',
+            'chrome_version_info',

[gregoryd, 2010/08/20 22:03:28]

Since chrome_version_info generates a library from a cc file, it must have a
win64-specific target. common_nacl_win64 is a 64-bit target and cannot link with
the 32-bit chrome_version_info. I am puzzled by the fact that the trybot
succeeded.

[gregoryd, 2010/08/20 23:20:04]

I think the explanation is that it links fine also without this line. Please
remove it.

             'common_constants_win64',
             '../app/app.gyp:app_base_nacl_win64',
             '../app/app.gyp:app_resources',
             '../base/base.gyp:base_nacl_win64',
             '../ipc/ipc.gyp:ipc_win64',
             '../third_party/libxml/libxml.gyp:libxml',
           ],
           'include_dirs': [
             '../third_party/npapi',
             '../third_party/icu/public/i18n',
@@ skipping 27 matching lines @@
           'configurations': {
             'Common_Base': {
               'msvs_target_platform': 'x64',
             },
           },
         },
       ],
     }],
   ],
 }