Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 311001: Back out r29592 (-Wl,-pie) because apparently Valgrind doesn't understand executable slide (Closed)

Created:
11 years, 2 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan, TVL
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Back out r29592 (-Wl,-pie) because apparently Valgrind doesn't understand executable slide. BUG=25372 TEST=green tree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
TBR (redness)
11 years, 2 months ago (2009-10-21 02:47:44 UTC) #1
stuartmorgan
11 years, 2 months ago (2009-10-21 16:35:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698