build/common.gypi - Issue 311001: Back out r29592 (-Wl,-pie) because apparently Valgrind doesn't understand executable slide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 311001: Back out r29592 (-Wl,-pie) because apparently Valgrind doesn't understand executable slide (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

===================================================================

--- build/common.gypi (revision 29601)

+++ build/common.gypi (working copy)

@@ -742,13 +742,6 @@

['_mac_bundle', {

'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},

}],

- ['_type=="executable"', {

- 'xcode_settings': {

- 'OTHER_LDFLAGS': [

- '-Wl,-pie', # Position-independent executable (MH_PIE)

- ],

- },

- }],

['_type=="executable" or _type=="shared_library"', {

'target_conditions': [

['mac_real_dsym == 1', {

« no previous file with comments | « no previous file | no next file » | no next file with comments »