Issue 3108027: Convert GetDisplayStringInLTRDirectionality from wstring to string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3108027: Convert GetDisplayStringInLTRDirectionality from wstring to string16. (Closed)

Created:
10 years, 4 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, Paul Godavari, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Convert GetDisplayStringInLTRDirectionality from wstring to string16. BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56535

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -52 lines)			Patch
M	app/text_elider.cc	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	app/text_elider_unittest.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	base/i18n/rtl.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	base/i18n/rtl.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	base/i18n/rtl_unittest.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/custom_home_pages_table_model.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/download/download_item_model.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/possible_url_model.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/search_engines/template_url_table_model.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+5 lines, -5 lines	1 comment	Download
M	chrome/browser/task_manager.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/task_manager_resource_providers.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/download_item_view.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/views/options/passwords_page_view.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/status_bubble_views.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	views/controls/label.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 4 months ago (2010-08-18 00:38:08 UTC) #2

LGTM

http://codereview.chromium.org/3108027/diff/1/13
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/3108027/diff/1/13#newcode3166
chrome/browser/tab_contents/tab_contents.cc:3166:
UTF8ToWide(profile()->GetPrefs()->GetString(prefs::kAcceptLanguages))));
I think there's a GetStringUTF16 now

Expand Messages | Collapse Messages