chrome/browser/views/options/passwords_page_view.cc - Issue 3108027: Convert GetDisplayStringInLTRDirectionality from wstring to string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/options/passwords_page_view.cc

Issue 3108027: Convert GetDisplayStringInLTRDirectionality from wstring to string16. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/options/passwords_page_view.cc

diff --git a/chrome/browser/views/options/passwords_page_view.cc b/chrome/browser/views/options/passwords_page_view.cc

index a3396833c52be4404f54b8b124ddf8eaa0c6ab15..3b33c1b6929871072c9b52d44bab6e84e9dbe533 100644

--- a/chrome/browser/views/options/passwords_page_view.cc

+++ b/chrome/browser/views/options/passwords_page_view.cc

@@ -73,7 +73,8 @@ std::wstring PasswordsTableModel::GetText(int row,

case IDS_PASSWORDS_PAGE_VIEW_SITE_COLUMN: { // Site.

// Force URL to have LTR directionality.

std::wstring url(saved_signons_[row]->display_url.display_url());

- base::i18n::GetDisplayStringInLTRDirectionality(&url);

+ url = UTF16ToWide(base::i18n::GetDisplayStringInLTRDirectionality(

+ WideToUTF16(url)));

return url;

}

case IDS_PASSWORDS_PAGE_VIEW_USERNAME_COLUMN: { // Username.