Issue 3106014: Remove 'options' usage from scm.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3106014: Remove 'options' usage from scm.py (Closed)

Created:
10 years, 4 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Remove 'options' usage from scm.py This is towards cleaning up the mess with 'options' in gclient_scm.py. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56213

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -18 lines)			Patch
M	gclient_scm.py	View	6 chunks	+11 lines, -6 lines	0 comments	Download
M	scm.py	View	3 chunks	+2 lines, -3 lines	1 comment	Download
M	tests/gclient_scm_test.py	View	9 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

10 years, 4 months ago (2010-08-16 16:51:44 UTC) #2

LGTM

http://codereview.chromium.org/3106014/diff/1/3
File scm.py (left):

http://codereview.chromium.org/3106014/diff/1/3#oldcode400
scm.py:400: args: A sequence of command line parameters to be passed to svn.
add verbose here?

Expand Messages | Collapse Messages