Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: scm.py

Issue 3106014: Remove 'options' usage from scm.py (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient_scm.py ('k') | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 79432423b0e05159a8a3e2b3d30bc94003416429..4e6449335230e3ea8ca055f2a8e264042880f80c 100644
--- a/scm.py
+++ b/scm.py
@@ -386,7 +386,7 @@ class SVN(object):
stderr=stderr).communicate()[0]
@staticmethod
- def RunAndGetFileList(options, args, in_directory, file_list):
+ def RunAndGetFileList(verbose, args, in_directory, file_list):
"""Runs svn checkout, update, or status, output to stdout.
The first item in args must be either "checkout", "update", or "status".
@@ -396,7 +396,6 @@ class SVN(object):
sys.stdout as in Run.
Args:
- options: command line options to gclient
args: A sequence of command line parameters to be passed to svn.
nsylvain 2010/08/16 16:51:45 add verbose here?
in_directory: The directory where svn is to be run.
@@ -442,7 +441,7 @@ class SVN(object):
try:
SVN.RunAndFilterOutput(args,
in_directory,
- options.verbose,
+ verbose,
True,
CaptureMatchingLines)
except gclient_utils.Error:
« no previous file with comments | « gclient_scm.py ('k') | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698