Cleanup the code in gclient_utils to standardize on CheckCall nomenclature.

Cleanup the code in gclient_utils to standardize on CheckCall nomenclature.
Simplify code by removing fail_status
Rename print_messages to always
Simplify the doc.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58201

[M-A Ruel, 2010-08-26 02:54:02]

The end goal still being to be able to not corrupt output with --jobs N.

[bradn, 2010-08-26 04:50:12]

LGTM

http://codereview.chromium.org/3104036/diff/3001/4003
File gclient_utils.py (right):

http://codereview.chromium.org/3104036/diff/3001/4003#newcode291
gclient_utils.py:291: stdout: Can be any bufferable output.
print_stdout

[M-A Ruel, 2010-08-26 04:57:46]

http://codereview.chromium.org/3104036/diff/3001/4003
File gclient_utils.py (right):

http://codereview.chromium.org/3104036/diff/3001/4003#newcode291
gclient_utils.py:291: stdout: Can be any bufferable output.
On 2010/08/26 04:50:12, bradn wrote:
> print_stdout

No, really stdout. Yeah, it's misleading. Will try to get a better
idea/description/name.

[bradn, 2010-08-26 04:58:23]

Ah, yes, LGTM

[M-A Ruel, 2010-08-31 17:19:25]

I'm sorry I added another patchset with significant changes as I had introduced
a regression. You can just compared patchset 3 to patchset 2 (3 files) + gcl.py
and tests/gclient_scm_tests.py. I removed a significant amount of useless code.
yay.

[M-A Ruel, 2010-09-01 13:32:25]

On 2010/08/31 17:19:25, Marc-Antoine Ruel wrote:
> I'm sorry I added another patchset with significant changes as I had
introduced
> a regression. You can just compared patchset 3 to patchset 2 (3 files) +
gcl.py
> and tests/gclient_scm_tests.py. I removed a significant amount of useless
code.
> yay.

Can you take a look today?

[bradn, 2010-09-01 17:53:12]

LGTM