gcl.py - Issue 3104036: Cleanup the code in gclient_utils to standardize on CheckCall nomenclature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 3104036: Cleanup the code in gclient_utils to standardize on CheckCall nomenclature. (Closed)

Patch Set: Rewrote the patch in part as I had introduced regressions. Removed a lot of dead code Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 0230c6222745824715add32a515dd3f9b827ab6d..bb623436d916e9862993692b9253554d9f71114f 100755

--- a/gcl.py

+++ b/gcl.py

@@ -150,8 +150,8 @@ def GetCachedFile(filename, max_age=60*60*24*3, use_root=False):

# The fix doesn't work if the user upgraded to svn 1.6.x. Bleh.

# I don't have time to fix their broken stuff.

args.append('--non-interactive')

- SVN.RunAndFilterOutput(args, cwd='.',

- filter_fn=content_array.append)

+ gclient_utils.CheckCallAndFilter(

+ args, cwd='.', filter_fn=content_array.append)

# Exit the loop if the file was found. Override content.

content = '\n'.join(content_array)

break

« no previous file with comments | « no previous file | gclient.py » ('j') | no next file with comments »