Issue 3086017: Add tabs to passwords and exceptions subpage

Issue 3086017: Add tabs to passwords and exceptions subpage (Closed)

Created:
10 years, 4 months ago by sargrass

Modified:
9 years, 7 months ago

Reviewers:
csilv, arv (Not doing code reviews), zel

CC:
chromium-reviews, dhg, ben+cc_chromium.org, James Hawkins, kuchhal, arv (Not doing code reviews), Evan Stade, stuartmorgan

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Add tabs to passwords and exceptions subpage. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55177

Patch Set 2 : share the common part between content setting and passwords exceptions #

Total comments: 2

Patch Set 3 : add todo for mac #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -50 lines)			Patch
M	chrome/browser/dom_ui/passwords_exceptions_handler.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/options/content_settings.html	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/options/content_settings.js	View		2 chunks	+0 lines, -25 lines	0 comments	Download
M	chrome/browser/resources/options/import_data_overlay.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/import_data_overlay.js	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/passwords_exceptions.html	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/passwords_exceptions.js	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.js	View	2	1 chunk	+11 lines, -3 lines	0 comments	Download
A +	chrome/browser/resources/options/subpages_tab_controls.css	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/3086017/diff/1/4 File chrome/browser/resources/options/passwords_exceptions.css (right): http://codereview.chromium.org/3086017/diff/1/4#newcode7 chrome/browser/resources/options/passwords_exceptions.css:7: #passwords-exceptions-nav-tabs .inactive-tab { This looks like copy-pasted code. Can ...

10 years, 4 months ago (2010-08-05 00:17:45 UTC) #2

sargrass

10 years, 4 months ago (2010-08-05 21:36:42 UTC) #3

arv1

> Done. I put the common part in options_page.js. Not sure if that's ok. That ...

10 years, 4 months ago (2010-08-05 22:17:10 UTC) #4

csilv

http://codereview.chromium.org/3086017/diff/7001/8011 File chrome/browser/resources/options/personal_options.js (right): http://codereview.chromium.org/3086017/diff/7001/8011#newcode54 chrome/browser/resources/options/personal_options.js:54: OptionsPage.showPageByName('passwordsExceptions'); As discussed, this will need to invoke the ...

10 years, 4 months ago (2010-08-05 22:53:41 UTC) #6

sargrass

10 years, 4 months ago (2010-08-05 23:39:14 UTC) #7

http://codereview.chromium.org/3086017/diff/7001/8011
File chrome/browser/resources/options/personal_options.js (right):

http://codereview.chromium.org/3086017/diff/7001/8011#newcode54
chrome/browser/resources/options/personal_options.js:54:
OptionsPage.showPageByName('passwordsExceptions');
On 2010/08/05 22:53:41, csilv wrote:
> As discussed, this will need to invoke the Keychain on MacChrome.  Might want
to
> add a TODO for that.

Done.

Expand Messages | Collapse Messages