Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/resources/options/import_data_overlay.js

Issue 3086017: Add tabs to passwords and exceptions subpage (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: add todo for mac Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/import_data_overlay.js
diff --git a/chrome/browser/resources/options/import_data_overlay.js b/chrome/browser/resources/options/import_data_overlay.js
index 66eb594e338af968da9d224922a3d4f723525245..8bca170abcddb56b4b83df2718560fcf13a5bfe9 100644
--- a/chrome/browser/resources/options/import_data_overlay.js
+++ b/chrome/browser/resources/options/import_data_overlay.js
@@ -18,7 +18,7 @@ cr.define('options', function() {
}
ImportDataOverlay.throbIntervalId = 0
- ImportDataOverlay.checkboxMask = "";
+ ImportDataOverlay.checkboxMask = '';
cr.addSingletonGetter(ImportDataOverlay);
@@ -34,8 +34,9 @@ cr.define('options', function() {
OptionsPage.prototype.initializePage.call(this);
var self = this;
- var checkboxList = $('checkboxList').getElementsByTagName('input');
- for (var i = 0; i < checkboxList.length; ++i) {
+ var checkboxList =
+ document.querySelectorAll('#checkboxList input[type=checkbox]');
+ for (var i = 0; i < checkboxList.length; i++) {
if(checkboxList[i].type == 'checkbox')
checkboxList[i].onchange = function(e) {
self.countCheckboxes_();
@@ -56,8 +57,9 @@ cr.define('options', function() {
countCheckboxes_: function() {
ImportDataOverlay.checkboxMask = "";
- var checkboxList = $('checkboxList').getElementsByTagName('input');
- for (var i = 0; i < checkboxList.length; ++i) {
+ var checkboxList =
+ document.querySelectorAll('#checkboxList input[type=checkbox]');
+ for (var i = 0; i < checkboxList.length; i++) {
if (checkboxList[i].type == 'checkbox') {
if(checkboxList[i].checked)
ImportDataOverlay.checkboxMask += "1";
« no previous file with comments | « chrome/browser/resources/options/import_data_overlay.html ('k') | chrome/browser/resources/options/options_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698