Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 3083016: Fix GCC 4.4.4 build.... (Closed)

Created:
10 years, 4 months ago by agl
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix GCC 4.4.4 build. Fedora has pushed GCC 4.4.4 to FC12 and that breaks the v8 build due to a GCC bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39509 This change works around the issue.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -26 lines) Patch
M src/heap.cc View 1 chunk +0 lines, -26 lines 0 comments Download
A src/heap-gcchack.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
Dear V8 folks. GCC 4.4.4 got pushed to Fedora 12 and broke the build. This ...
10 years, 4 months ago (2010-08-04 21:07:17 UTC) #1
Evan Martin
I asked my local C++ expert and he suggests that if we really want it ...
10 years, 4 months ago (2010-08-04 21:37:39 UTC) #2
Evan Martin
10 years, 4 months ago (2010-08-04 21:37:52 UTC) #3
Søren Thygesen Gjesse
10 years, 4 months ago (2010-08-05 12:36:03 UTC) #4
On 2010/08/04 21:37:52, Evan Martin wrote:
> 

Decided on the __attribute__((noinline)), see
http://codereview.chromium.org/3034056

Closing issue.

Powered by Google App Engine
This is Rietveld 408576698