Issue 3034056: Fix GCC 4.4.4 build...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3034056: Fix GCC 4.4.4 build... (Closed)

Created:
10 years, 4 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Fix GCC 4.4.4 build Force a number functions to not inline in order th work around a bug in GCC 4.4.4. See http://codereview.chromium.org/3083016 for more info. Committed: http://code.google.com/p/v8/source/detail?r=5179

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	src/globals.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/heap.h	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Søren Thygesen Gjesse

This has not been tested with GCC 3, so I am not sure the NO_INLINE ...

10 years, 4 months ago (2010-08-05 11:49:16 UTC) #1

Vyacheslav Egorov (Chromium)

10 years, 4 months ago (2010-08-05 12:03:30 UTC) #2

I checked GCC manual for 3.x versions and can confirm that noinline is mentioned
in docs starting from 3.1.

So I think we can use it. 

LGTM.