Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: chrome/browser/chromeos/login/google_authenticator_unittest.cc

Issue 3077006: Fix nit for oshima (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/google_authenticator_unittest.cc
diff --git a/chrome/browser/chromeos/login/google_authenticator_unittest.cc b/chrome/browser/chromeos/login/google_authenticator_unittest.cc
index d9583870410310b63a4fde239f120f8ddc5476a2..4676ff0ea1e5881017a8143c544c557eee563bd2 100644
--- a/chrome/browser/chromeos/login/google_authenticator_unittest.cc
+++ b/chrome/browser/chromeos/login/google_authenticator_unittest.cc
@@ -61,7 +61,7 @@ class ExpectCanceledFetcher : public URLFetcher {
: URLFetcher(url, request_type, d) {
}
- ~ExpectCanceledFetcher() {
+ virtual ~ExpectCanceledFetcher() {
task_->Cancel();
}
@@ -518,6 +518,8 @@ TEST_F(GoogleAuthenticatorTest, CheckLocalaccount) {
auth->CheckLocalaccount(std::string());
}
+namespace {
+
// Compatible with LoginStatusConsumer::OnLoginSuccess()
static void OnSuccessQuit(
const std::string& username,
@@ -542,6 +544,8 @@ static void OnFailQuitAndFail(const std::string& error) {
MessageLoop::current()->Quit();
}
+} // anonymous namespace
+
TEST_F(GoogleAuthenticatorTest, LocalaccountLogin) {
// This test checks the logic that governs asynchronously reading the
// localaccount name off disk and trying to authenticate against it
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698