Fix nit for oshima

chrome/browser/chromeos/login/google_authenticator_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
@@ skipping 43 matching lines @@
 // canceled, and fails the test if it is not
 class ExpectCanceledFetcher : public URLFetcher {
  public:
   ExpectCanceledFetcher(bool success,
                         const GURL& url,
                         URLFetcher::RequestType request_type,
                         URLFetcher::Delegate* d)
       : URLFetcher(url, request_type, d) {
   }
 
-  ~ExpectCanceledFetcher() {
+  virtual ~ExpectCanceledFetcher() {
     task_->Cancel();
   }
 
   static void CompleteFetch() {
     ADD_FAILURE() << "Fetch completed in ExpectCanceledFetcher!";
     MessageLoop::current()->Quit();  // Allow exiting even if we mess up.
   }
 
   void Start() {
     LOG(INFO) << "Delaying fetch completion in mock";
@@ skipping 436 matching lines @@
       .WillOnce(Return(true))
       .RetiresOnSaturation();
 
   scoped_refptr<GoogleAuthenticator> auth(new GoogleAuthenticator(&consumer));
   PrepForLogin(auth.get());
   auth->SetLocalaccount(username_);
 
   auth->CheckLocalaccount(std::string());
 }
 
+namespace {
+
 // Compatible with LoginStatusConsumer::OnLoginSuccess()
 static void OnSuccessQuit(
     const std::string& username,
     const GaiaAuthConsumer::ClientLoginResult& credentials) {
   MessageLoop::current()->Quit();
 }
 
 static void OnSuccessQuitAndFail(
     const std::string& username,
     const GaiaAuthConsumer::ClientLoginResult& credentials) {
   ADD_FAILURE() << "Login should NOT have succeeded!";
   MessageLoop::current()->Quit();
 }
 
 // Compatible with LoginStatusConsumer::OnLoginFailure()
 static void OnFailQuit(const std::string& error) {
   MessageLoop::current()->Quit();
 }
 
 static void OnFailQuitAndFail(const std::string& error) {
   ADD_FAILURE() << "Login should have succeeded!";
   MessageLoop::current()->Quit();
 }
 
+}  // anonymous namespace
+
 TEST_F(GoogleAuthenticatorTest, LocalaccountLogin) {
   // This test checks the logic that governs asynchronously reading the
   // localaccount name off disk and trying to authenticate against it
   // simultaneously.
   MessageLoop message_loop(MessageLoop::TYPE_UI);
   ChromeThread ui_thread(ChromeThread::UI, &message_loop);
 
   MockConsumer consumer;
   EXPECT_CALL(consumer, OnLoginSuccess(username_, _))
       .WillOnce(Invoke(OnSuccessQuit))
@@ skipping 161 matching lines @@
   // Post a task to cancel the login attempt.
   CancelLogin(auth.get());
 
   URLFetcher::set_factory(NULL);
 
   // Run the UI thread until we exit it gracefully.
   message_loop.Run();
 }
 
 }  // namespace chromeos