Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 3077006: Fix nit for oshima (Closed)

Created:
10 years, 4 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, ben+cc_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix nit for oshima http://src.chromium.org/viewvc/chrome?view=rev&revision=53913 accidentally landed a cleaned up version of the change reviewed in http://codereview.chromium.org/2847080/show This change introduces a style nit fix, but is also so that someone can review the ExpectCanceledFetcher (which replaces and simplifies TimedMockFetcher) in google_authenticator_unittest.cc BUG=None TEST=unit tests

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/chromeos/login/google_authenticator_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
10 years, 4 months ago (2010-07-28 15:52:52 UTC) #1
oshima
10 years, 4 months ago (2010-07-28 17:45:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698