Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 3076027: Merge 54782 - [Mac] Adjust toolbar spacing of browser actions for M6.... (Closed)

Created:
10 years, 4 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

Merge 54782 - [Mac] Adjust toolbar spacing of browser actions for M6. Toolbar.xib change brings browser-action container view out from under Omnibox. Push browser-action sizing code into controller to reduce exposed constants. Make size consistent with other toolbar buttons. 4px visual spacing from omnibox to first browser action (grippy in that area), between browser actions, and last action to wrench menu. browser_actions_overflow_Template.pdf resource for browser-action chevron. Chevron same height as browser actions. Get rid of divider between browser actions and wrench (future CL will integrate it into chevron button). Chevron 4px from Omnibox or 2px from last browser action, then 4px to wrench menu. Chevron button has hover like other buttons. BUG=50575 TEST=Browser-actions area still works right WRT spacing and rearranging and everything else. Review URL: http://codereview.chromium.org/3012044 TBR=shess@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -76 lines) Patch
M chrome/app/nibs/Toolbar.xib View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/app/theme/browser_actions_overflow_Template.pdf View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/cocoa/extensions/browser_action_button.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/cocoa/extensions/browser_action_button.mm View 3 chunks +5 lines, -17 lines 0 comments Download
M chrome/browser/cocoa/extensions/browser_actions_container_view.mm View 2 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/cocoa/extensions/browser_actions_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/extensions/browser_actions_controller.mm View 8 chunks +55 lines, -27 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Scott Hess - ex-Googler
10 years, 4 months ago (2010-08-03 23:28:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698