[Mac] Adjust toolbar spacing of browser actions for M6.

[Mac] Adjust toolbar spacing of browser actions for M6.

Toolbar.xib change brings browser-action container view out from under
Omnibox.

Push browser-action sizing code into controller to reduce exposed
constants.  Make size consistent with other toolbar buttons.  4px
visual spacing from omnibox to first browser action (grippy in that
area), between browser actions, and last action to wrench menu.

browser_actions_overflow_Template.pdf resource for browser-action
chevron.  Chevron same height as browser actions.  Get rid of divider
between browser actions and wrench (future CL will integrate it into
chevron button).  Chevron 4px from Omnibox or 2px from last browser
action, then 4px to wrench menu.  Chevron button has hover like other
buttons.

BUG=50575
TEST=Browser-actions area still works right WRT spacing and rearranging and everything else.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54782

[Scott Hess - ex-Googler, 2010-08-03 06:38:02]

Andy, I think this is about right, but based on an afternoon of getting bitten
by missed tricks, I'd not be surprised if I'm missing something in there.  I
tested various versions of dragging by the grippy, dragging actions around, and
disabling extensions.

Hmm.  Forgot to check that the popup was being positioning with the top border
at the right place.  That should be localized, I'll push it up tomorrow morning.

[Bons, 2010-08-03 16:29:37]

LGTM

Things look fine, just moved around. I'll play around with some use cases on ToT
and let you know if I see anything.

Nice work.

http://codereview.chromium.org/3012044/diff/1/8
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/3012044/diff/1/8#newcode10
chrome/browser/cocoa/extensions/browser_actions_controller.mm:10: #include
"app/resource_bundle.h"
do we still need this header since we're using the nsimage cache?

[Scott Hess - ex-Googler, 2010-08-03 18:00:23]

On 2010/08/03 16:29:37, Andrew Bonventre (Bons) wrote:
> Things look fine, just moved around. I'll play around with some use cases on
ToT
> and let you know if I see anything.

OK - I've checked it in.  I'll hold off on merging to branch for a little bit,
though.

http://codereview.chromium.org/3012044/diff/1/8
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/3012044/diff/1/8#newcode10
chrome/browser/cocoa/extensions/browser_actions_controller.mm:10: #include
"app/resource_bundle.h"
On 2010/08/03 16:29:38, Andrew Bonventre (Bons) wrote:
> do we still need this header since we're using the nsimage cache?

Done.  Also grit/theme_resources.h.