Move NSImage-to-CGImageRef conversion code into a common helper function in base/mac_util.h.

Move NSImage-to-CGImageRef conversion code into a common helper function in base/mac_util.h.

BUG=49571
TEST=Covered by unit_tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53997

[Avi (use Gerrit), 2010-07-28 15:52:45]

http://codereview.chromium.org/3072005/diff/1/2
File base/mac_util.h (right):

http://codereview.chromium.org/3072005/diff/1/2#newcode145
base/mac_util.h:145: // Covnerts a NSImage to a CGImageRef.  Normally, the
system frameworks can do
tpyo

http://codereview.chromium.org/3072005/diff/1/3
File base/mac_util.mm (right):

http://codereview.chromium.org/3072005/diff/1/3#newcode482
base/mac_util.mm:482: // Covnerts a NSImage to a CGImageRef.  Normally, the
system frameworks can do
typo

[Nico, 2010-07-28 16:01:16]

lg, thanks!

http://codereview.chromium.org/3072005/diff/6001/7001
File base/mac_util.h (right):

http://codereview.chromium.org/3072005/diff/6001/7001#newcode149
base/mac_util.h:149: // releasing the return value.
If the caller is responsible for freeing, should the fucntion name then contain
the word "Copy" somewhere to stay consistent with the CF naming rule?

http://codereview.chromium.org/3072005/diff/6001/7002
File base/mac_util.mm (right):

http://codereview.chromium.org/3072005/diff/6001/7002#newcode498
base/mac_util.mm:498: kCGImageAlphaPremultipliedFirst);
do you want to return early if context is NULL?

(If so, you can use a scoped_cftyperef for context, too)

[Robert Sesek, 2010-07-28 16:18:15]

http://codereview.chromium.org/3072005/diff/6001/7001
File base/mac_util.h (right):

http://codereview.chromium.org/3072005/diff/6001/7001#newcode149
base/mac_util.h:149: // releasing the return value.
On 2010/07/28 16:01:16, Nico wrote:
> If the caller is responsible for freeing, should the fucntion name then
contain
> the word "Copy" somewhere to stay consistent with the CF naming rule?

Done.

http://codereview.chromium.org/3072005/diff/6001/7002
File base/mac_util.mm (right):

http://codereview.chromium.org/3072005/diff/6001/7002#newcode498
base/mac_util.mm:498: kCGImageAlphaPremultipliedFirst);
On 2010/07/28 16:01:16, Nico wrote:
> do you want to return early if context is NULL?
> 
> (If so, you can use a scoped_cftyperef for context, too)

Done.

[Nico, 2010-07-28 16:21:50]

LG!