Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3068004: base/ header cleanup. Forward declaration instead of including. (Closed)

Created:
10 years, 5 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paul Godavari, Alpha Left Google, idana, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, dpranke+watch_chromium.org, Aaron Boodman, fbarchard, pam+watch_chromium.org, awong, Paweł Hajdan Jr., kuchhal, darin-cc_chromium.org, tim (not reviewing), scherkus (not reviewing), nkostylev+cc_chromium.org, davemoore+watch_chromium.org, amit
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

base/ header cleanup. Forward declaration instead of including. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53969

Patch Set 1 #

Total comments: 1

Patch Set 2 : mac fixes #

Patch Set 3 : win compile fixes #

Patch Set 4 : More windows compile fixes #

Patch Set 5 : More win fix #

Patch Set 6 : win fix again #

Patch Set 7 : chromeos/win fixes #

Patch Set 8 : more chromeos compile fixes #

Patch Set 9 : win (image_diff) compile fixes #

Patch Set 10 : mini_installer_test_util.cc #

Patch Set 11 : win ffmpeg_tests fixes + jhawkins comments #

Patch Set 12 : views' examples_main.cc fix" #

Patch Set 13 : chrome/app/client_util.cc #

Patch Set 14 : chrome_frame_test_utils.cc #

Patch Set 15 : chrome_frame_test_utils.cc part 2 #

Patch Set 16 : ie_event_sink.cc fix #

Patch Set 17 : task_manager_view.cc #

Patch Set 18 : chrome_launcher_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -62 lines) Patch
M base/command_line.h View 1 2 3 4 5 6 7 7 chunks +11 lines, -32 lines 0 comments Download
M base/command_line.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +43 lines, -0 lines 0 comments Download
M base/command_line_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/data_pack.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M base/data_pack.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/histogram.h View 1 2 3 4 5 6 7 7 chunks +11 lines, -20 lines 0 comments Download
M base/histogram.cc View 6 chunks +45 lines, -0 lines 0 comments Download
M base/process_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/process_util.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M base/process_util_posix.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M base/process_util_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/test_suite.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/client_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_init_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_theme_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/configuration_policy_pref_store_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/first_run.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/first_run_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox2_importer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/toolbar_importer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/platform_util_common_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/process_info_snapshot_mac.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_bloom.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/shell_integration.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/task_manager_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_plugin_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/sandbox_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/logging_installer.cc View 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/live_sync/live_autofill_sync_test.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/chrome_launcher_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.h View 1 chunk +1 line, -5 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 14 3 chunks +7 lines, -0 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/filters/ffmpeg_video_decode_engine.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/test/ffmpeg_tests/ffmpeg_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/tools/media_bench/media_bench.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/tools/omx_test/omx_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/tools/scaler_bench/scaler_bench.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/tools/wav_ola_test/wav_ola_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/test_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/imagediff/image_diff.cc View 1 chunk +1 line, -0 lines 0 comments Download
M views/examples/examples_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
(The only interesting changes are in base/ ; everything else is me adding includes)
10 years, 5 months ago (2010-07-26 21:27:00 UTC) #1
James Hawkins
10 years, 5 months ago (2010-07-27 21:08:49 UTC) #2 
LGTM!

http://codereview.chromium.org/3068004/diff/1/2
File base/command_line.cc (right):

http://codereview.chromium.org/3068004/diff/1/2#newcode401
base/command_line.cc:401: 
nit: Remove extra blank line.

Powered by Google App Engine
This is Rietveld 408576698