chrome_frame/test/chrome_frame_test_utils.h - Issue 3068004: base/ header cleanup. Forward declaration instead of including.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/test/chrome_frame_test_utils.h

Issue 3068004: base/ header cleanup. Forward declaration instead of including. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: chrome_launcher_unittest.cc Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/test/chrome_frame_test_utils.h

diff --git a/chrome_frame/test/chrome_frame_test_utils.h b/chrome_frame/test/chrome_frame_test_utils.h

index 13177fcba6c50acaf717e86334c806aafd1c121d..4b74f1e3637bafff07b90fdfdfb97dde1e255f6e 100644

--- a/chrome_frame/test/chrome_frame_test_utils.h

+++ b/chrome_frame/test/chrome_frame_test_utils.h

@@ -374,11 +374,7 @@ void DelaySendExtendedKeysEnter(TimedMsgLoop* loop, int delay, char c,

class CloseIeAtEndOfScope {

public:

CloseIeAtEndOfScope() {}

- ~CloseIeAtEndOfScope() {

- int closed = CloseAllIEWindows();

- DLOG_IF(ERROR, closed != 0)

- << StringPrintf("Closed %i windows forcefully", closed);

- }

+ ~CloseIeAtEndOfScope();

};

// Starts the Chrome crash service which enables us to gather crash dumps