Issue 3067017: Merge 53457 - Disable proxy config button and show banner if proxy prefs are managed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3067017: Merge 53457 - Disable proxy config button and show banner if proxy prefs are managed. (Closed)

Created:
10 years, 4 months ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Merge 53457 - Disable proxy config button and show banner if proxy prefs are managed. Preferences.xib changes: Connect Enabled of the proxies configuration button to a getter in PreferencesWindowController. BUG=49538 TEST=Unit test in pref_set_observer_unittest.cc, manually configure proxy policies, check advanced options page. Review URL: http://codereview.chromium.org/3038013 TBR=mnissler@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54121

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+395 lines, -4 lines)			Patch
M	chrome/app/nibs/Preferences.xib	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/options/advanced_contents_gtk.cc	View	4 chunks	+23 lines, -3 lines	0 comments	Download
M	chrome/browser/managed_prefs_banner_base.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
	chrome/browser/pref_service.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/pref_set_observer.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	chrome/browser/pref_set_observer.cc	View	1 chunk	+66 lines, -0 lines	0 comments	Download
A	chrome/browser/pref_set_observer_unittest.cc	View	1 chunk	+88 lines, -0 lines	0 comments	Download
M	chrome/browser/views/options/advanced_contents_view.cc	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	3 chunks	+4 lines, -1 line	0 comments	Download
A	chrome/test/testing_pref_service.h	View	1 chunk	+52 lines, -0 lines	0 comments	Download
A	chrome/test/testing_pref_service.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download