Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 3066031: Merge 54714 - Recommit 54405 - Fix late binding induced mismatch of Socket an... (Closed)

Created:
10 years, 4 months ago by vandebo (ex-Chrome)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 54714 - Recommit 54405 - Fix late binding induced mismatch of Socket and AuthController ClientSocketPool treats all pending SocketParams as interchangeable. Therefore they can not contain any connection specific data. This only affects the Http Proxy tunnel case. The lowest risk change to fix this problem is to create the HttpAuthController in the HttpProxyClientSocket. If we get a 407 and need to restart the Tunnel, the pending HttpProxyClientSocket is returned to the HttpNetworkTransaction in the additional error state of the connection and then complete the auth in a pair of states in the HttpNetworkTransaction. This reintroduces a dependency between tunnel setup and the HttpNetworkTransaction, but that will need to be fixed at a later date. Original Review URL: http://codereview.chromium.org/3058013 BUG=49493 TEST=existing unit tests + manually visiting many SSL sites through a kerberized http proxy. Review URL: http://codereview.chromium.org/3029052 TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54732

Patch Set 1 #

Patch Set 2 : Fix merge problems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -431 lines) Patch
M net/base/net_error_list.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M net/http/http_network_transaction.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 8 chunks +88 lines, -40 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 4 chunks +151 lines, -37 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 1 4 chunks +11 lines, -6 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 7 chunks +36 lines, -16 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 16 chunks +37 lines, -31 lines 0 comments Download
M net/socket/client_socket_handle.h View 3 chunks +7 lines, -0 lines 0 comments Download
M net/socket/client_socket_handle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 1 chunk +0 lines, -39 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +1 line, -47 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 5 chunks +8 lines, -20 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 28 chunks +50 lines, -178 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
vandebo (ex-Chrome)
10 years, 4 months ago (2010-08-03 10:09:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698