Recommit 54405 - Fix late binding induced mismatch of Socket and AuthController

Recommit 54405 - Fix late binding induced mismatch of Socket and AuthController

ClientSocketPool treats all pending SocketParams as interchangeable. Therefore they can not contain any connection specific data. This only affects the Http Proxy tunnel case. The lowest risk change to fix this problem is to create the HttpAuthController in the HttpProxyClientSocket. If we get a 407 and need to restart the Tunnel, the pending HttpProxyClientSocket is returned to the HttpNetworkTransaction in the additional error state of the connection and then complete the auth in a pair of states in the HttpNetworkTransaction. This reintroduces a dependency between tunnel setup and the HttpNetworkTransaction, but that will need to be fixed at a later date. 

Original Review URL: http://codereview.chromium.org/3058013

BUG=49493
TEST=existing unit tests + manually visiting many SSL sites through a kerberized http proxy.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54714

[vandebo (ex-Chrome), 2010-08-03 04:59:48]

I generated this CL by locally reverting 54647, 54616, then 54614.  Unit tests
pass.  Let me know if something else needs to be updated.

[cbentzel, 2010-08-03 15:29:10]

LGTM

On Tue, Aug 3, 2010 at 12:59 AM, <vandebo@chromium.org> wrote:

> Reviewers: cbentzel,
>
> Message:
> I generated this CL by locally reverting 54647, 54616, then 54614.  Unit
> tests
> pass.  Let me know if something else needs to be updated.
>
> Description:
> Recommit 54405 - Fix late binding induced mismatch of Socket and
> AuthController
>
> ClientSocketPool treats all pending SocketParams as interchangeable.
> Therefore
> they can not contain any connection specific data. This only affects the
> Http
> Proxy tunnel case. The lowest risk change to fix this problem is to create
> the
> HttpAuthController in the HttpProxyClientSocket. If we get a 407 and need
> to
> restart the Tunnel, the pending HttpProxyClientSocket is returned to the
> HttpNetworkTransaction in the additional error state of the connection and
> then
> complete the auth in a pair of states in the HttpNetworkTransaction. This
> reintroduces a dependency between tunnel setup and the
> HttpNetworkTransaction,
> but that will need to be fixed at a later date.
>
> Original Review URL: http://codereview.chromium.org/3058013
>
> BUG=49493
> TEST=existing unit tests + manually visiting many SSL sites through a
> kerberized
> http proxy.
>
> Please review this at http://codereview.chromium.org/3029052/show
>
> Affected files:
>  M net/base/net_error_list.h
>  M net/http/http_network_transaction.h
>  net/http/http_network_transaction.cc
>  M net/http/http_network_transaction_unittest.cc
>  M net/http/http_proxy_client_socket.h
>  M net/http/http_proxy_client_socket.cc
>  M net/http/http_proxy_client_socket_pool.h
>  M net/http/http_proxy_client_socket_pool.cc
>  M net/http/http_proxy_client_socket_pool_unittest.cc
>  M net/socket/client_socket_handle.h
>  M net/socket/client_socket_handle.cc
>  M net/socket/socket_test_util.h
>  M net/socket/socket_test_util.cc
>  M net/socket/ssl_client_socket_pool.h
>  M net/socket/ssl_client_socket_pool.cc
>  M net/socket/ssl_client_socket_pool_unittest.cc
>
>
>