Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: remoting/client/plugin/pepper_view.cc

Issue 3064009: Initial scriptable object implementation. (Closed)
Patch Set: Fix alpha's style nits. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/client/plugin/chromoting_scriptable_object.cc ('k') | remoting/client/x11_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/pepper_view.cc
diff --git a/remoting/client/plugin/pepper_view.cc b/remoting/client/plugin/pepper_view.cc
index c2f353848b78d97e2f173bddfc176ba4ae7fe6d4..9e6a7af328576cf3d391bdb4ea62111ce4a590f9 100644
--- a/remoting/client/plugin/pepper_view.cc
+++ b/remoting/client/plugin/pepper_view.cc
@@ -43,12 +43,14 @@ void PepperView::Paint() {
return;
}
- // TODO(ajwong): We shouldn't assume the image data format.
- pp::ImageData image(PP_IMAGEDATAFORMAT_BGRA_PREMUL,
+ // TODO(ajwong): We're assuming the native format is BGRA_PREMUL below. This
+ // is wrong.
+ pp::ImageData image(pp::ImageData::GetNativeImageDataFormat(),
pp::Size(viewport_width_, viewport_height_),
false);
if (image.is_null()) {
- LOG(ERROR) << "Unable to allocate image.";
+ LOG(ERROR) << "Unable to allocate image of size: "
+ << viewport_width_ << "x" << viewport_height_;
return;
}
« no previous file with comments | « remoting/client/plugin/chromoting_scriptable_object.cc ('k') | remoting/client/x11_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698