Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/chromeos/login/google_authenticator.cc

Issue 3061019: Make canceled login fail over to offline, instead of just failing (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/google_authenticator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/google_authenticator.cc
diff --git a/chrome/browser/chromeos/login/google_authenticator.cc b/chrome/browser/chromeos/login/google_authenticator.cc
index 94361be00606337d575159a885ce81d3673b8be7..af093d9d6cc72fdfd7eac1cfd859f76d2d5ebf9d 100644
--- a/chrome/browser/chromeos/login/google_authenticator.cc
+++ b/chrome/browser/chromeos/login/google_authenticator.cc
@@ -45,7 +45,7 @@ namespace chromeos {
const char GoogleAuthenticator::kLocalaccountFile[] = "localaccount";
// static
-const int GoogleAuthenticator::kClientLoginTimeoutMs = 5000;
+const int GoogleAuthenticator::kClientLoginTimeoutMs = 15000;
Nikita (slow) 2010/07/27 10:06:57 Isn't 15s too much since we always have an option
// static
const int GoogleAuthenticator::kLocalaccountRetryIntervalMs = 20;
@@ -64,7 +64,7 @@ GoogleAuthenticator::~GoogleAuthenticator() {}
void GoogleAuthenticator::CancelClientLogin() {
if (gaia_authenticator_->HasPendingFetch()) {
gaia_authenticator_->CancelRequest();
- OnLoginFailure("Login has timed out; please try again!");
+ CheckOffline("Login has timed out; please try again!");
}
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/google_authenticator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698