Make canceled login fail over to offline, instead of just failing

chrome/browser/chromeos/login/google_authenticator.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/google_authenticator.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_path.h"
@@ skipping 27 matching lines @@
 using file_util::PathExists;
 using file_util::ReadFile;
 using file_util::ReadFileToString;
 
 namespace chromeos {
 
 // static
 const char GoogleAuthenticator::kLocalaccountFile[] = "localaccount";
 
 // static
-const int GoogleAuthenticator::kClientLoginTimeoutMs = 5000;
+const int GoogleAuthenticator::kClientLoginTimeoutMs = 15000;

[Nikita (slow), 2010/07/27 10:06:57]

Isn't 15s too much since we always have an option to fail to offline login?

 // static
 const int GoogleAuthenticator::kLocalaccountRetryIntervalMs = 20;
 
 const int kPassHashLen = 32;
 
 GoogleAuthenticator::GoogleAuthenticator(LoginStatusConsumer* consumer)
     : Authenticator(consumer),
       unlock_(false),
       try_again_(true),
       checked_for_localaccount_(false) {
   CHECK(chromeos::CrosLibrary::Get()->EnsureLoaded());
 }
 
 GoogleAuthenticator::~GoogleAuthenticator() {}
 
 void GoogleAuthenticator::CancelClientLogin() {
   if (gaia_authenticator_->HasPendingFetch()) {
     gaia_authenticator_->CancelRequest();
-    OnLoginFailure("Login has timed out; please try again!");
+    CheckOffline("Login has timed out; please try again!");
   }
 }
 
 void GoogleAuthenticator::TryClientLogin() {
   gaia_authenticator_->StartClientLogin(username_,
                                         password_,
                                         GaiaAuthenticator2::kContactsService,
                                         login_token_,
                                         login_captcha_);
   ChromeThread::PostDelayedTask(
@@ skipping 344 matching lines @@
   DCHECK_EQ(parts.size(), 2U) << "email_address should have only one @";
   RemoveChars(parts[0], ".", &parts[0]);
   if (parts[0].find('+') != std::string::npos)
     parts[0].erase(parts[0].find('+'));
   std::string new_email = StringToLowerASCII(JoinString(parts, at));
   LOG(INFO) << "Canonicalized " << email_address << " to " << new_email;
   return new_email;
 }
 
 }  // namespace chromeos