Issue 3061019: Make canceled login fail over to offline, instead of just failing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3061019: Make canceled login fail over to offline, instead of just failing (Closed)

Created:
10 years, 5 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Make canceled login fail over to offline, instead of just failing Also, increase login timeout. BUG=None TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53789

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/login/google_authenticator.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download
	M	chrome/browser/chromeos/login/google_authenticator_unittest.cc	View		4 chunks	+42 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

LGTM http://codereview.chromium.org/3061019/diff/1/2 File chrome/browser/chromeos/login/google_authenticator.cc (right): http://codereview.chromium.org/3061019/diff/1/2#newcode48 chrome/browser/chromeos/login/google_authenticator.cc:48: const int GoogleAuthenticator::kClientLoginTimeoutMs = 15000; Isn't 15s too ...

10 years, 5 months ago (2010-07-27 10:06:56 UTC) #2

Chris Masone

On Tue, Jul 27, 2010 at 3:06 AM, <nkostylev@chromium.org> wrote: > LGTM > > > ...

10 years, 5 months ago (2010-07-27 14:38:42 UTC) #3

Nikita (slow)

10 years, 5 months ago (2010-07-27 14:43:53 UTC) #4

As discussed 10sec might be fine since we'll fail over tooffline login.
If something is wrong with the network delaying login even more is not worth it.

Expand Messages | Collapse Messages