Issue 306025: Revert 29646 - Fix cmdoptleft/right....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306025: Revert 29646 - Fix cmdoptleft/right.... (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert 29646 - Fix cmdoptleft/right. This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmdoptleft meant cmdleft and swallowed the event. BUG=25396 TEST=Focus text box in web. cmdoptleft/right should switch tabs, cmdleft/right should move cursor in text box. Focus web background. cmdoptleft/right should switch tabs, cmdleft/right should do history navigation. Focus omnibox. cmdoptleft/right should still switch tabs, cmdleft/right should move cursor. cmd1/2 should switch tabs in all three places, cmdopt1/2 should not do anything. Review URL: http://codereview.chromium.org/313004 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -36 lines)			Patch
M	chrome/browser/cocoa/chrome_event_processing_window.mm	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/global_keyboard_shortcuts_mac.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/global_keyboard_shortcuts_mac.mm	View	5 chunks	+24 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LG.

Expand Messages | Collapse Messages