Issue 313004: Fix cmd-opt-left/right.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313004: Fix cmd-opt-left/right. (Closed)

Created:
11 years, 2 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), jeremy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix cmd-opt-left/right. This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event. BUG=25396 TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29660

Patch Set 1 #

Patch Set 2 : Fix unittest compile #

Patch Set 3 : Rebase ToT #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -35 lines)			Patch
M	chrome/browser/cocoa/chrome_event_processing_window.mm	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/global_keyboard_shortcuts_mac.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/global_keyboard_shortcuts_mac.mm	View	5 chunks	+28 lines, -24 lines	0 comments	Download
M	chrome/browser/global_keyboard_shortcuts_mac_unittest.cc	View	4 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm, thanks for the quick turnaround.

Expand Messages | Collapse Messages