Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 3060045: Making window.focus() work in Chrome (Closed)

Created:
10 years, 4 months ago by Jay Civelli
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Making window.focus() work in Chrome. A patch on the WebKit side https://bugs.webkit.org/show_bug.cgi?id=43542 ensures we get the correct notification when window.focus()/blur() is called. This CL makes the browser active/unactive in response to the focus/blur message. BUG=29643 TEST=Visit gmail. Open an IM conversation window and pop-it out. Focus the browser (so the IM window is in the back). Click on the person name in the IM section of gmail. The conversation window should be brought back to the front. Repeat but this time minimize the conversation window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55678

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 3

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -18 lines) Patch
M chrome/browser/browser.h View 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browser.cc View 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/browser_window.h View 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.h View 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/notifications/balloon_host.h View 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 3 4 5 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.h View 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 2 3 4 5 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 2 3 4 5 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.cc View 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view.h View 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view.cc View 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/render_widget.cc View 1 2 3 4 5 1 chunk +1 line, -7 lines 0 comments Download
M chrome/test/test_browser_window.h View 5 1 chunk +1 line, -0 lines 0 comments Download
M views/window/window.h View 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M views/window/window_gtk.h View 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M views/window/window_gtk.cc View 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M views/window/window_win.h View 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M views/window/window_win.cc View 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jay Civelli
10 years, 4 months ago (2010-08-06 06:54:49 UTC) #1
Ben Goodger (Google)
10 years, 4 months ago (2010-08-09 19:26:05 UTC) #2
LGTM

http://codereview.chromium.org/3060045/diff/15003/53005
File chrome/browser/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/3060045/diff/15003/53005#newcode112
chrome/browser/cocoa/browser_window_cocoa.mm:112: // TODO(jcivelli):
http://crbug.com/51364 Implement me.
NOTIMPLEMENTED?

http://codereview.chromium.org/3060045/diff/15003/53008
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/3060045/diff/15003/53008#newcode714
chrome/browser/gtk/browser_window_gtk.cc:714: // TODO(jcivelli):
http://crbug.com/51364 Implement me.
NOTIMPLEMENTED?

http://codereview.chromium.org/3060045/diff/15003/53027
File views/window/window_gtk.cc (right):

http://codereview.chromium.org/3060045/diff/15003/53027#newcode134
views/window/window_gtk.cc:134: // TODO(jcivelli): http://crbug.com/51364
Implement me.
NOTIMPLEMENTED

Powered by Google App Engine
This is Rietveld 408576698