Issue 3059005: o3d-webgl: Increasing the point size in shader to make points easier to see.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3059005: o3d-webgl: Increasing the point size in shader to make points easier to see. (Closed)

Created:
10 years, 5 months ago by luchen

Modified:
9 years, 7 months ago

Reviewers:
petersont

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

o3d-webgl: Increasing the point size in shader to make points easier to see. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53856

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	samples/o3d-webgl-samples/hellocube-wireframe.html	View	1	2 chunks	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petersont

10 years, 5 months ago (2010-07-27 21:49:09 UTC) #2

LGTM.

http://codereview.chromium.org/3059005/diff/2001/3001
File samples/o3d-webgl-samples/hellocube-wireframe.html (right):

http://codereview.chromium.org/3059005/diff/2001/3001#newcode406
samples/o3d-webgl-samples/hellocube-wireframe.html:406: gl_PointSize = 5.0;
You can do that?

Expand Messages | Collapse Messages