Issue 3058049: Do not apply JS_RETURN and DEBUG_BREAK_SLOT relocations on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3058049: Do not apply JS_RETURN and DEBUG_BREAK_SLOT relocations on x64. (Closed)

Created:
10 years, 4 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Do not apply JS_RETURN and DEBUG_BREAK_SLOT relocations on x64. Improve tests for debug API to check behavior of JS_RETURN and DEBUG_BREAK_SLOT relocations. Committed: http://code.google.com/p/v8/source/detail?r=5180

Patch Set 1 #

Patch Set 2 : fixed assertions #

Patch Set 3 : removed break slot/return from ::apply #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -44 lines)			Patch
M	src/arm/assembler-arm-inl.h	View	1	2 chunks	+8 lines, -10 lines	0 comments	Download
M	src/assembler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View		1 chunk	+10 lines, -9 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 2	2 chunks	+6 lines, -13 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		1 chunk	+34 lines, -8 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 4 months ago (2010-08-05 13:26:29 UTC) #3

LGTM

http://codereview.chromium.org/3058049/diff/10001/11006
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/3058049/diff/10001/11006#newcode1301
test/cctest/test-debug.cc:1301: foo = CompileFunction(&env, "function
bar(){};function foo(){bar();}", "foo");
Long line.

Expand Messages | Collapse Messages