Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 3058046: Fix gsdcurl to correctly URL-quote a password passed via GSDCURL_PASSWORD (Closed)

Created:
10 years, 4 months ago by jrbarnette
Modified:
9 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

Fix gsdcurl to correctly URL-quote a password passed via GSDCURL_PASSWORD BUG=none TEST=use this script with a (correct) password that includes punctuation such as one of these: $&+,/:;=?@

Patch Set 1 #

Patch Set 2 : eliminate incorrectly added stray file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M bin/cros_gsdcurl.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jrbarnette
10 years, 4 months ago (2010-08-05 00:55:30 UTC) #1
bradn
10 years, 4 months ago (2010-08-05 17:49:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698