bin/cros_gsdcurl.py - Issue 3058046: Fix gsdcurl to correctly URL-quote a password passed via GSDCURL_PASSWORD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bin/cros_gsdcurl.py

Issue 3058046: Fix gsdcurl to correctly URL-quote a password passed via GSDCURL_PASSWORD (Closed) Base URL: ssh://gitrw.chromium.org/crosutils.git

Patch Set: eliminate incorrectly added stray file Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: bin/cros_gsdcurl.py

diff --git a/bin/cros_gsdcurl.py b/bin/cros_gsdcurl.py

index e046fe2795e84c20d90940d6f38c3e9606750f41..ed024f3fc40e3a5e1532a1c2cae08d8dea27b302 100755

--- a/bin/cros_gsdcurl.py

+++ b/bin/cros_gsdcurl.py

@@ -27,11 +27,11 @@ def Authenticate():

passwd = os.environ.get('GSDCURL_PASSWORD')

if passwd is None:

sys.stderr.write('Password: ')

- passwd = urllib.quote_plus(getpass.getpass(prompt=''))

+ passwd = getpass.getpass(prompt='')

cmd = [

'curl', '--silent', 'https://www.google.com/accounts/ClientLogin',

'-d', 'Email=' + username,

- '-d', 'Passwd=' + passwd,

+ '-d', 'Passwd=' + urllib.quote_plus(passwd),

'-d', 'accountType=GOOGLE',

'-d', 'source=Google-gsdcurl-ver1',

'-d', 'service=cds',

« no previous file with comments | « no previous file | no next file » | no next file with comments »