Issue 3057033: Remove GetSwitchValue() from chrome/* where easy.

Issue 3057033: Remove GetSwitchValue() from chrome/* where easy. (Closed)

Created:
10 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, viettrungluu

CC:
chromium-reviews, cbentzel+watch_chromium.org, John Grabowski, amit, Paweł Hajdan Jr., jam, pam+watch_chromium.org, brettw-cc_chromium.org, kuchhal, darin-cc_chromium.org, native-client-reviews_googlegroups.com, ben+cc_chromium.org, Paul Godavari, stuartmorgan+watch_chromium.org

Visibility:
Public.

Description

Remove GetSwitchValue() from chrome/* where easy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55176

Patch Set 1 #

Patch Set 2 : fixed #

Patch Set 3 : passes trybots #

Patch Set 4 : passes trybots #

Patch Set 5 : maybe ok #

Patch Set 6 : fix #

Patch Set 7 : finally #

Total comments: 4

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -138 lines)			Patch
M	chrome/browser/first_run/first_run_win.cc	View	3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/filter_false_positive_perftest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_plugin_util.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/pepper_plugin_registry.cc	View	1 2 3 4 5	2 chunks	+17 lines, -9 lines	0 comments	Download
M	chrome/common/sandbox_init_wrapper_mac.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/sandbox_policy.cc	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/setup/setup_main.cc	View	1 2 3 4 5 6	9 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/installer/setup/uninstall.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/logging_installer.h	View	2	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/installer/util/logging_installer.cc	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/installer/util/master_preferences.cc	View	1 2 3 4	2 chunks	+3 lines, -2 lines	1 comment	Download
M	chrome/installer/util/shell_util.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/installer/util/util_constants.h	View	3 4 5 6	1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/installer/util/util_constants.cc	View	3 4 5 6	3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/nacl/nacl_main_platform_delegate_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/plugin/plugin_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/plugin/webplugin_delegate_stub.cc	View		1 chunk	+3 lines, -3 lines	1 comment	Download
M	chrome/renderer/devtools_client.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_main.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/renderer_main_platform_delegate_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/mini_installer_test/test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/reliability/page_load_test.cc	View		4 chunks	+21 lines, -17 lines	0 comments	Download
M	chrome/test/test_launcher/out_of_proc_test_runner.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View		1 chunk	+14 lines, -14 lines	0 comments	Download
M	chrome/test/ui/ui_test_suite.cc	View	1 2	2 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/test/url_fetch_test/url_fetch_test.cc	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/tools/crash_service/crash_service.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/test/net/process_singleton_subclass.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -2 lines	1 comment	Download
M	chrome_frame/test/reliability/page_load_test.cc	View	1 2 3 4 5	3 chunks	+12 lines, -8 lines	1 comment	Download
M	chrome_frame/test/reliability/run_all_unittests.cc	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

After this change, there are only like four instances left in the whole project.

10 years, 4 months ago (2010-08-05 23:57:45 UTC) #1

tony

10 years, 4 months ago (2010-08-06 00:09:38 UTC) #2

LGTM

http://codereview.chromium.org/3057033/diff/16001/17012
File chrome/installer/util/master_preferences.cc (right):

http://codereview.chromium.org/3057033/diff/16001/17012#newcode8
chrome/installer/util/master_preferences.cc:8: #include "base/string_util.h"
Nit: sort

http://codereview.chromium.org/3057033/diff/16001/17018
File chrome/plugin/webplugin_delegate_stub.cc (right):

http://codereview.chromium.org/3057033/diff/16001/17018#newcode170
chrome/plugin/webplugin_delegate_stub.cc:170: ;
Nit: semicolon on wrong line?

http://codereview.chromium.org/3057033/diff/16001/17029
File chrome_frame/test/net/process_singleton_subclass.cc (right):

http://codereview.chromium.org/3057033/diff/16001/17029#newcode105
chrome_frame/test/net/process_singleton_subclass.cc:105:
switches::kAutomationClientChannelID);
Nit: This can probably fit on 2 lines.

http://codereview.chromium.org/3057033/diff/16001/17030
File chrome_frame/test/reliability/page_load_test.cc (right):

http://codereview.chromium.org/3057033/diff/16001/17030#newcode565
chrome_frame/test/reliability/page_load_test.cc:565: kStartIndexSwitch),
Nit: Can this line (and the ones below it) be merge with the previous?

Expand Messages | Collapse Messages