Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7434)

Unified Diff: chrome_frame/test/reliability/page_load_test.cc

Issue 3057033: Remove GetSwitchValue() from chrome/* where easy. (Closed)
Patch Set: finally Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/reliability/page_load_test.cc
diff --git a/chrome_frame/test/reliability/page_load_test.cc b/chrome_frame/test/reliability/page_load_test.cc
index 2e44e043427428dabbb292cf34ebb990753b9378..39a40dca918ff472a33ce8f97f088028d04ba89b 100644
--- a/chrome_frame/test/reliability/page_load_test.cc
+++ b/chrome_frame/test/reliability/page_load_test.cc
@@ -561,15 +561,17 @@ void SetPageRange(const CommandLine& parsed_command_line) {
if (parsed_command_line.HasSwitch(kStartIndexSwitch)) {
ASSERT_TRUE(
- base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue(
- kStartIndexSwitch)), &g_start_index));
+ base::StringToInt(parsed_command_line.GetSwitchValue(
+ kStartIndexSwitch),
tony 2010/08/06 00:09:38 Nit: Can this line (and the ones below it) be merg
+ &g_start_index));
ASSERT_GT(g_start_index, 0);
}
if (parsed_command_line.HasSwitch(kEndIndexSwitch)) {
ASSERT_TRUE(
- base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue(
- kEndIndexSwitch)), &g_end_index));
+ base::StringToInt(parsed_command_line.GetSwitchValue(
+ kEndIndexSwitch),
+ &g_end_index));
ASSERT_GT(g_end_index, 0);
}
@@ -580,8 +582,9 @@ void SetPageRange(const CommandLine& parsed_command_line) {
if (parsed_command_line.HasSwitch(kIterationSwitch)) {
ASSERT_TRUE(
- base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue(
- kIterationSwitch)), &g_iterations));
+ base::StringToInt(parsed_command_line.GetSwitchValue(
+ kIterationSwitch),
+ &g_iterations));
ASSERT_GT(g_iterations, 0);
}
@@ -596,8 +599,9 @@ void SetPageRange(const CommandLine& parsed_command_line) {
if (parsed_command_line.HasSwitch(kTimeoutSwitch)) {
ASSERT_TRUE(
- base::StringToInt(WideToUTF16(parsed_command_line.GetSwitchValue(
- kTimeoutSwitch)), &g_timeout_ms));
+ base::StringToInt(parsed_command_line.GetSwitchValue(
+ kTimeoutSwitch),
+ &g_timeout_ms));
ASSERT_GT(g_timeout_ms, 0);
}

Powered by Google App Engine
This is Rietveld 408576698