Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 3056003: Attemp 2 at: (Closed)

Created:
10 years, 5 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Attemp 2 at: Makes the toolbar visible for apps again. Here's the set of patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566) If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none TBR=finnur Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53204

Patch Set 1 #

Patch Set 2 : Fix chromeos breakage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -464 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/browser_window.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/tab_controller.mm View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/location_bar.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/tab_menu_model.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/tab_menu_model.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/tab_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 5 chunks +0 lines, -52 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/view_ids.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 8 chunks +1 line, -29 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 10 chunks +13 lines, -57 lines 0 comments Download
M chrome/browser/views/frame/browser_view_layout.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/views/frame/browser_view_layout.cc View 7 chunks +3 lines, -43 lines 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip_controller.cc View 2 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.h View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/views/toolbar_view.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 5 chunks +2 lines, -27 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/notification_type.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/test_browser_window.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/test_location_bar.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
Initial landing broke chromeos because a chromeos file was depending upon an include in a ...
10 years, 5 months ago (2010-07-20 20:27:51 UTC) #1
Finnur
10 years, 5 months ago (2010-07-21 08:59:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698