Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2867)

Unified Diff: chrome/browser/tabs/tab_strip_model.cc

Issue 3056003: Attemp 2 at: (Closed)
Patch Set: Fix chromeos breakage Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tabs/tab_strip_model.h ('k') | chrome/browser/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tabs/tab_strip_model.cc
diff --git a/chrome/browser/tabs/tab_strip_model.cc b/chrome/browser/tabs/tab_strip_model.cc
index 9fe21e64862968f74df14bb366e950beba4ad265..22cea3b0ba48d5429890ca6f2dd08ffee857e491 100644
--- a/chrome/browser/tabs/tab_strip_model.cc
+++ b/chrome/browser/tabs/tab_strip_model.cc
@@ -121,9 +121,6 @@ TabStripModel::TabStripModel(TabStripModelDelegate* delegate, Profile* profile)
registrar_.Add(this,
NotificationType::EXTENSION_UNLOADED,
Source<Profile>(profile_));
- registrar_.Add(this,
- NotificationType::EXTENSION_APP_TOOLBAR_VISIBILITY_CHANGED,
- NotificationService::AllSources());
order_controller_ = new TabStripModelOrderController(this);
}
@@ -528,16 +525,6 @@ bool TabStripModel::IsAppTab(int index) const {
return contents && contents->is_app();
}
-bool TabStripModel::IsToolbarVisible(int index) const {
- Extension* extension_app = GetTabContentsAt(index)->extension_app();
- if (!extension_app)
- return true;
-
- ExtensionsService* service = profile()->GetExtensionsService();
- ExtensionPrefs* prefs = service->extension_prefs();
- return prefs->AreAppTabToolbarsVisible(extension_app->id());
-}
-
bool TabStripModel::IsPhantomTab(int index) const {
return IsTabPinned(index) &&
GetTabContentsAt(index)->controller().needs_reload();
@@ -708,8 +695,6 @@ bool TabStripModel::IsContextMenuCommandEnabled(
return delegate_->CanRestoreTab();
case CommandTogglePinned:
return true;
- case CommandToggleToolbar:
- return true;
case CommandBookmarkAllTabs:
return delegate_->CanBookmarkAllTabs();
case CommandUseVerticalTabs:
@@ -795,32 +780,6 @@ void TabStripModel::ExecuteContextMenuCommand(
}
break;
}
- case CommandToggleToolbar: {
- UserMetrics::RecordAction(
- UserMetricsAction("TabContextMenu_ToggleToolbar"),
- profile_);
-
- SelectTabContentsAt(context_index, true);
-
- Extension* extension_app =
- GetTabContentsAt(context_index)->extension_app();
- if (!extension_app)
- break;
-
- ExtensionsService* service = profile()->GetExtensionsService();
- ExtensionPrefs* prefs = service->extension_prefs();
- bool new_val = !prefs->AreAppTabToolbarsVisible(extension_app->id());
- prefs->SetAppTabToolbarVisibility(extension_app->id(), new_val);
-
- // There might be multiple browsers displaying this app, so we send a
- // notification to update them all.
- NotificationService::current()->Notify(
- NotificationType::EXTENSION_APP_TOOLBAR_VISIBILITY_CHANGED,
- Source<Extension>(extension_app),
- Details<bool>(&new_val));
-
- break;
- }
case CommandBookmarkAllTabs: {
UserMetrics::RecordAction(
@@ -907,17 +866,6 @@ void TabStripModel::Observe(NotificationType type,
break;
}
- case NotificationType::EXTENSION_APP_TOOLBAR_VISIBILITY_CHANGED: {
- Extension* extension = Source<Extension>(source).ptr();
- bool* value = Details<bool>(details).ptr();
- TabContents* selected = GetSelectedTabContents();
-
- if (selected && selected->extension_app() == extension)
- delegate_->SetToolbarVisibility(*value);
-
- break;
- }
-
default:
NOTREACHED();
}
« no previous file with comments | « chrome/browser/tabs/tab_strip_model.h ('k') | chrome/browser/tabs/tab_strip_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698