Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 3053008: Second attempt at trying to land buggy bho avoidance: http://codereview.chrom... (Closed)

Created:
10 years, 5 months ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Second attempt at trying to land buggy bho avoidance: http://codereview.chromium.org/3031009 A different approach to avoid crashes in buggy 3rd party BHOs.This time we're more preceise and only target the buggy components.Behaviour for components that handle browser events correctly, is unchanged even in the presence of buggy DLLs.The core class here is the BuggyBhoTls class and here's the comment for that class: // Construct an instance of this class on the stack when firing web browser // events that can be sent to buggy BHOs. This class will intercept those // BHOs (see list in cc file) and ignore notifications to those components // for as long as the BuggyBhoTls instance on the stack lives. TEST=A better fix for bug 44463 but also fixes bug 49373 and a number of crashes that haven't been associated with bug reports yet. BUG=44463, 49373 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53236

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -69 lines) Patch
M chrome_frame/bind_context_info.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
A chrome_frame/buggy_bho_handling.h View 1 chunk +87 lines, -0 lines 0 comments Download
A chrome_frame/buggy_bho_handling.cc View 1 1 chunk +200 lines, -0 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 2 3 4 5 6 chunks +12 lines, -66 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome_frame/utils.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/utils.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome_frame/vtable_patch_manager.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698