chrome_frame/vtable_patch_manager.cc - Issue 3053008: Second attempt at trying to land buggy bho avoidance: http://codereview.chrom...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/vtable_patch_manager.cc

Issue 3053008: Second attempt at trying to land buggy bho avoidance: http://codereview.chrom... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_frame/vtable_patch_manager.cc

===================================================================

--- chrome_frame/vtable_patch_manager.cc (revision 53233)

+++ chrome_frame/vtable_patch_manager.cc (working copy)

@@ -4,9 +4,10 @@

#include "chrome_frame/vtable_patch_manager.h"

-#include <algorithm>

#include <atlcomcli.h>

+#include <algorithm>

#include "base/atomicops.h"

#include "base/lock.h"

#include "base/logging.h"

@@ -90,7 +91,7 @@

FunctionStub* stub = NULL;

#ifndef NDEBUG

- FunctionStub::FromCode(original_fn);

+ stub = FunctionStub::FromCode(original_fn);

if (stub != NULL) {

DLOG(ERROR) << "attempt to patch a function that's already patched";

DCHECK(stub->destination_function() ==

« no previous file with comments | « chrome_frame/utils.cc ('k') | no next file » | no next file with comments »