base: Rename EnvVarGetter to Environment.

base: Rename EnvVarGetter to Environment.

Now EnvVarGetter do much more than getting environment variables.

Per suggestion from Pawel in http://codereview.chromium.org/3043018/.

BUG=None
TEST=trybots

Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54696

[tfarina, 2010-07-31 22:47:02]

Sorry for this big CL.

[viettrungluu, 2010-07-31 23:02:12]

Driving by....

http://codereview.chromium.org/3052034/diff/1/10
File base/linux_util.cc (right):

http://codereview.chromium.org/3052034/diff/1/10#newcode20
base/linux_util.cc:20: #include "base/environment.h"
This seems like an unnecessary #include. Delete.

http://codereview.chromium.org/3052034/diff/1/11
File base/linux_util.h (right):

http://codereview.chromium.org/3052034/diff/1/11#newcode18
base/linux_util.h:18: class Environment;
This seems like an unused forward declaration. Delete.

http://codereview.chromium.org/3052034/diff/1/24
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/3052034/diff/1/24#newcode9
chrome/browser/profile.cc:9: #include "base/environment.h"
Seems unnecessary.

http://codereview.chromium.org/3052034/diff/1/43
File media/audio/audio_input_controller_unittest.cc (right):

http://codereview.chromium.org/3052034/diff/1/43#newcode5
media/audio/audio_input_controller_unittest.cc:5: #include "base/environment.h"
Seems unnecessary. Plus it's out of order.

[tfarina, 2010-08-01 00:45:00]

Good catches trungluu!

http://codereview.chromium.org/3052034/diff/1/10
File base/linux_util.cc (right):

http://codereview.chromium.org/3052034/diff/1/10#newcode20
base/linux_util.cc:20: #include "base/environment.h"
On 2010/07/31 23:02:12, viettrungluu wrote:
> This seems like an unnecessary #include. Delete.

Done.

http://codereview.chromium.org/3052034/diff/1/11
File base/linux_util.h (right):

http://codereview.chromium.org/3052034/diff/1/11#newcode18
base/linux_util.h:18: class Environment;
On 2010/07/31 23:02:12, viettrungluu wrote:
> This seems like an unused forward declaration. Delete.

Done.

http://codereview.chromium.org/3052034/diff/1/24
File chrome/browser/profile.cc (right):

http://codereview.chromium.org/3052034/diff/1/24#newcode9
chrome/browser/profile.cc:9: #include "base/environment.h"
On 2010/07/31 23:02:12, viettrungluu wrote:
> Seems unnecessary.

Removed.

http://codereview.chromium.org/3052034/diff/1/43
File media/audio/audio_input_controller_unittest.cc (right):

http://codereview.chromium.org/3052034/diff/1/43#newcode5
media/audio/audio_input_controller_unittest.cc:5: #include "base/environment.h"
On 2010/07/31 23:02:12, viettrungluu wrote:
> Seems unnecessary. Plus it's out of order.
Removed.

[Paweł Hajdan Jr., 2010-08-02 17:35:57]

I only looked at the base/environment bits assuming all the rest are trivial
changes.

http://codereview.chromium.org/3052034/diff/8001/9007
File base/environment.h (right):

http://codereview.chromium.org/3052034/diff/8001/9007#newcode33
base/environment.h:33: virtual bool GetEnv(const char* variable_name,
std::string* result) = 0;
nit: Now the names should probably be GetVar, HasVar, SetVar, UnSetVar...

[tfarina, 2010-08-02 23:46:08]

On 2010/08/02 17:35:57, Paweł Hajdan Jr. wrote:
> I only looked at the base/environment bits assuming all the rest are trivial
> changes.
> 
> http://codereview.chromium.org/3052034/diff/8001/9007
> File base/environment.h (right):
> 
> http://codereview.chromium.org/3052034/diff/8001/9007#newcode33
> base/environment.h:33: virtual bool GetEnv(const char* variable_name,
> std::string* result) = 0;
> nit: Now the names should probably be GetVar, HasVar, SetVar, UnSetVar...

Yup! These changes should be done in this CL or can done in a followup patch?

[Paweł Hajdan Jr., 2010-08-03 00:16:40]

Up to you.

On Mon, Aug 2, 2010 at 16:46, <tfarina@chromium.org> wrote:

> On 2010/08/02 17:35:57, Paweł Hajdan Jr. wrote:
>
>> I only looked at the base/environment bits assuming all the rest are
>> trivial
>> changes.
>>
>
>  http://codereview.chromium.org/3052034/diff/8001/9007
>> File base/environment.h (right):
>>
>
>  http://codereview.chromium.org/3052034/diff/8001/9007#newcode33
>> base/environment.h:33: virtual bool GetEnv(const char* variable_name,
>> std::string* result) = 0;
>> nit: Now the names should probably be GetVar, HasVar, SetVar, UnSetVar...
>>
>
> Yup! These changes should be done in this CL or can done in a followup
> patch?
>
>
> http://codereview.chromium.org/3052034/show
>

[tfarina, 2010-08-03 02:08:17]

On 2010/08/03 00:16:40, Paweł Hajdan Jr. wrote:
> Up to you.
> 
Going to do this in a next CL so.

can I get a LGTM?

[Lei Zhang, 2010-08-03 02:16:23]

LGTM rubberstamp.