Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: base/xdg_util_unittest.cc

Issue 3052034: base: Rename EnvVarGetter to Environment. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: review Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/xdg_util_unittest.cc
diff --git a/base/xdg_util_unittest.cc b/base/xdg_util_unittest.cc
index 24671b1628ee6029ddbaea40d00b018230277bf4..c876466ca01e96ed56bb555dbfd7e7169e1e5263 100644
--- a/base/xdg_util_unittest.cc
+++ b/base/xdg_util_unittest.cc
@@ -4,7 +4,7 @@
#include "base/xdg_util.h"
-#include "base/env_var.h"
+#include "base/environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -15,7 +15,7 @@ using ::testing::StrEq;
namespace {
-class MockEnvVarGetter : public base::EnvVarGetter {
+class MockEnvironment : public base::Environment {
public:
MOCK_METHOD2(GetEnv, bool(const char*, std::string* result));
MOCK_METHOD2(SetEnv, bool(const char*, const std::string& new_value));
@@ -30,7 +30,7 @@ const char* kXFCE = "xfce";
} // namespace
TEST(XDGUtilTest, GetDesktopEnvironmentGnome) {
- MockEnvVarGetter getter;
+ MockEnvironment getter;
EXPECT_CALL(getter, GetEnv(_, _)).WillRepeatedly(Return(false));
EXPECT_CALL(getter, GetEnv(StrEq("DESKTOP_SESSION"), _))
.WillOnce(DoAll(SetArgumentPointee<1>(kGnome), Return(true)));
@@ -40,7 +40,7 @@ TEST(XDGUtilTest, GetDesktopEnvironmentGnome) {
}
TEST(XDGUtilTest, GetDesktopEnvironmentKDE4) {
- MockEnvVarGetter getter;
+ MockEnvironment getter;
EXPECT_CALL(getter, GetEnv(_, _)).WillRepeatedly(Return(false));
EXPECT_CALL(getter, GetEnv(StrEq("DESKTOP_SESSION"), _))
.WillOnce(DoAll(SetArgumentPointee<1>(kKDE4), Return(true)));
@@ -50,7 +50,7 @@ TEST(XDGUtilTest, GetDesktopEnvironmentKDE4) {
}
TEST(XDGUtilTest, GetDesktopEnvironmentKDE3) {
- MockEnvVarGetter getter;
+ MockEnvironment getter;
EXPECT_CALL(getter, GetEnv(_, _)).WillRepeatedly(Return(false));
EXPECT_CALL(getter, GetEnv(StrEq("DESKTOP_SESSION"), _))
.WillOnce(DoAll(SetArgumentPointee<1>(kKDE), Return(true)));
@@ -60,7 +60,7 @@ TEST(XDGUtilTest, GetDesktopEnvironmentKDE3) {
}
TEST(XDGUtilTest, GetDesktopEnvironmentXFCE) {
- MockEnvVarGetter getter;
+ MockEnvironment getter;
EXPECT_CALL(getter, GetEnv(_, _)).WillRepeatedly(Return(false));
EXPECT_CALL(getter, GetEnv(StrEq("DESKTOP_SESSION"), _))
.WillOnce(DoAll(SetArgumentPointee<1>(kXFCE), Return(true)));
« base/environment.h ('K') | « base/xdg_util.cc ('k') | chrome/browser/browser_init.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698