Issue 3052023: Remove some debug switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3052023: Remove some debug switches. (Closed)

Created:
10 years, 4 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
tkent

CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Remove some debug switches: --issue35198-crxdir-browser --issue35198-permission They were used to understand issue 35198. They are no longer needed. There is one more switch, --issue35198-logging, that is not being removed in this CL. The logging it adds may still be useful. BUG=50604 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54323

Patch Set 1 : Rebase. #

Patch Set 2 : Rebase. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -121 lines)			Patch
M	base/file_util.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/file_util_posix.cc	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	base/file_util_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	base/file_util_win.cc	View		5 chunks	+2 lines, -69 lines	0 comments	Download
M	base/scoped_temp_dir.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	base/scoped_temp_dir.cc	View		2 chunks	+2 lines, -7 lines	0 comments	Download
M	base/scoped_temp_dir_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/convert_user_script.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View		2 chunks	+1 line, -20 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages