Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.cc

Issue 3052023: Remove some debug switches. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Rebase. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/sandboxed_extension_unpacker.cc
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.cc b/chrome/browser/extensions/sandboxed_extension_unpacker.cc
index c0876490cca7dcb4b5213e354dc468569ef06104..2de1c09048589a922ed46a3a4229cc1bed4aa2c3 100644
--- a/chrome/browser/extensions/sandboxed_extension_unpacker.cc
+++ b/chrome/browser/extensions/sandboxed_extension_unpacker.cc
@@ -42,18 +42,8 @@ void SandboxedExtensionUnpacker::Start() {
// file IO on.
CHECK(ChromeThread::GetCurrentThreadIdentifier(&thread_identifier_));
- // To understand crbug/35198, allow users who can reproduce the bug
- // to loosen permissions on the scoped directory.
- bool loosen_permissions = false;
-#if defined (OS_WIN)
- loosen_permissions = CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kIssue35198Permission);
- LOG(INFO) << "loosen_permissions = " << loosen_permissions;
-#endif
-
// Create a temporary directory to work in.
- if (!temp_dir_.CreateUniqueTempDirUnderPath(temp_path_,
- loosen_permissions)) {
+ if (!temp_dir_.CreateUniqueTempDirUnderPath(temp_path_)) {
ReportFailure("Could not create temporary directory.");
return;
}
@@ -62,15 +52,6 @@ void SandboxedExtensionUnpacker::Start() {
extension_root_ = temp_dir_.path().AppendASCII(
extension_filenames::kTempExtensionName);
- // To understand crbug/35198, allow users who can reproduce the bug to
- // create the unpack directory in the browser process.
- bool crxdir_in_browser = CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kIssue35198CrxDirBrowser);
- LOG(INFO) << "crxdir_in_browser = " << crxdir_in_browser;
- if (crxdir_in_browser && !file_util::CreateDirectory(extension_root_)) {
- LOG(ERROR) << "Failed to create directory " << extension_root_.value();
- }
-
// Extract the public key and validate the package.
if (!ValidateSignature())
return; // ValidateSignature() already reported the error.
« no previous file with comments | « chrome/browser/extensions/convert_user_script.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698