Issue 3047009: Fix infinite recursion in PrebuiltsReady when graph is cyclic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3047009: Fix infinite recursion in PrebuiltsReady when graph is cyclic. (Closed)

Created:
10 years, 5 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
petkov, nsanders, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, zel

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Fix infinite recursion in PrebuiltsReady when graph is cyclic. Our package graph is cyclic, so parallel_emerge needs to handle cycles correctly in all cases. PrebuiltsReady should only need to check each package once, so we should set cache[pkg] to True if we found the package in the cache. TEST=Ran build_packages --fast BUG=none

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	parallel_emerge	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

davidjames

This should fix the problems regarding infinite recursion in PrebuiltsReady. I'm on a plane, so ...

10 years, 5 months ago (2010-07-21 21:09:18 UTC) #1

sosa

10 years, 5 months ago (2010-07-21 21:18:13 UTC) #3

LGTM -- wanted to test the patch fixed my issue and it worked :)

On Wed, Jul 21, 2010 at 2:14 PM,  <petkov@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/3047009/show
>

Expand Messages | Collapse Messages