Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: parallel_emerge

Issue 3047009: Fix infinite recursion in PrebuiltsReady when graph is cyclic. (Closed) Base URL: ssh://git@chromiumos-git/crosutils.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: parallel_emerge
diff --git a/parallel_emerge b/parallel_emerge
index 5b09ec6e428f8384160fe9624221555f5b30edc6..971e6a30b334dc1b211ea7a218f704e9e5eeb394 100755
--- a/parallel_emerge
+++ b/parallel_emerge
@@ -819,11 +819,12 @@ class DepGraphGenerator(object):
if pkg not in pkg_db:
cache[pkg] = False
else:
+ cache[pkg] = True
for dep in deps_map[pkg]["needs"]:
if not PrebuiltsReady(dep, pkg_db, cache):
cache[pkg] = False
break
- return cache.setdefault(pkg, True)
+ return cache[pkg]
def LastModifiedWithDeps(pkg, pkg_db, cache):
"""Calculate the last modified time of a package and its dependencies.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698