[Linux Views] Refactor accelerator handler related code.

[Linux Views] Refactor accelerator handler related code.

This CL removes the accelerator handling logic in
accelerator_handler_gtk.cc and implements a much simpler solution in
WidgetGtk. The new approach always sends a key event to the focused View
and native GtkWidget first and only sends it to the focus manager if it's not
handled by any View or native GtkWidget.

BUG=23383
AcceleratorHandler on Windows should not dispatch the KEYUP messages eaten by the FocusManager
BUG=40966
BrowserKeyEventsTest.AccessKeys is crashy
BUG=49701
[Linux Views]Some Emacs keybindings are broken in omnibox and find in page box.
TEST=Press Alt key in different place (web page, omnibox, find bar, etc.) to see if menu bar can be focused correctly. Press alt-F to popup wrench menu and Escape to close it, then try alt key again.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54947

[dmazzoni, 2010-08-03 19:21:42]

Code changes look okay to me.

Implementation is almost correct, but I found one issue:

1. Press Ctrl and keep it down.
2. Press Alt.
3. Release Alt - the menu is focused, but this should not happen.

Please check for similar issues.

[James Su, 2010-08-03 19:28:39]

On 2010/08/03 19:21:42, Dominic Mazzoni wrote:
> Code changes look okay to me.
> 
> Implementation is almost correct, but I found one issue:
> 
> 1. Press Ctrl and keep it down.
> 2. Press Alt.
> 3. Release Alt - the menu is focused, but this should not happen.
> 
> Please check for similar issues.

I remembered that Windows version has the same behavior. But apparently I'm
wrong. On Windows, ctrl+alt has no effect, but weird that shift+alt works.

I'll fix it asap.

[James Su, 2010-08-03 19:53:36]

CL has been updated to fix cases like ctrl+alt.

On 2010/08/03 19:28:39, James Su wrote:
> On 2010/08/03 19:21:42, Dominic Mazzoni wrote:
> > Code changes look okay to me.
> > 
> > Implementation is almost correct, but I found one issue:
> > 
> > 1. Press Ctrl and keep it down.
> > 2. Press Alt.
> > 3. Release Alt - the menu is focused, but this should not happen.
> > 
> > Please check for similar issues.
> 
> I remembered that Windows version has the same behavior. But apparently I'm
> wrong. On Windows, ctrl+alt has no effect, but weird that shift+alt works.
> 
> I'll fix it asap.

[James Su, 2010-08-04 16:57:34]

Any feedback?

[dmazzoni, 2010-08-04 17:37:54]

I'm happy, but I think either jcivelli or sky should take a look also.

- Dominic

On Wed, Aug 4, 2010 at 9:57 AM, <suzhe@chromium.org> wrote:

> Any feedback?
>
>
> http://codereview.chromium.org/3046041/show
>

[James Su, 2010-08-04 17:56:50]

Add sky.

On 2010/08/04 17:37:54, Dominic Mazzoni wrote:
> I'm happy, but I think either jcivelli or sky should take a look also.
> 
> - Dominic
> 
> On Wed, Aug 4, 2010 at 9:57 AM, <mailto:suzhe@chromium.org> wrote:
> 
> > Any feedback?
> >
> >
> > http://codereview.chromium.org/3046041/show
> >
>

[Jay Civelli, 2010-08-04 18:21:00]

LGTM

http://codereview.chromium.org/3046041/diff/4013/9012
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/3046041/diff/4013/9012#newcode888
views/widget/widget_gtk.cc:888: // trigger VKEY_MENU when only this key is
pressed and released, and both
Nit: Trigger

[sky, 2010-08-04 18:24:22]

As long as Jay reviewed this, you don't need me.

  -Scott

On Wed, Aug 4, 2010 at 10:56 AM,  <suzhe@chromium.org> wrote:
> Add sky.
>
> On 2010/08/04 17:37:54, Dominic Mazzoni wrote:
>>
>> I'm happy, but I think either jcivelli or sky should take a look also.
>
>> - Dominic
>
>> On Wed, Aug 4, 2010 at 9:57 AM, <mailto:suzhe@chromium.org> wrote:
>
>> > Any feedback?
>> >
>> >
>> > http://codereview.chromium.org/3046041/show
>> >
>
>
>
>
> http://codereview.chromium.org/3046041/show
>