[Linux Views] Refactor accelerator handler related code.

chrome/browser/renderer_host/gtk_im_context_wrapper.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/gtk_im_context_wrapper.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 #include <algorithm>
@@ skipping 114 matching lines @@
     filtered = gtk_im_context_filter_keypress(context_, event);
   } else {
     filtered = gtk_im_context_filter_keypress(context_simple_, event);
   }
 
   // Reset this flag here, as it's only used in input method callbacks.
   is_in_key_event_handler_ = false;
 
   NativeWebKeyboardEvent wke(event);
 
+  // If the key event was handled by the input method, then we need to prevent
+  // RenderView::UnhandledKeyboardEvent() from processing it.
+  // Otherwise unexpected result may occur. For example if it's a
+  // Backspace key event, the browser may go back to previous page.
+  if (filtered)
+    wke.skip_in_browser = true;
+
   // Send filtered keydown event before sending IME result.
   if (event->type == GDK_KEY_PRESS && filtered)
     ProcessFilteredKeyPressEvent(&wke);
 
   // Send IME results. In most cases, it's only available if the key event
   // is filtered by IME. But in rare cases, an unfiltered key event may also
   // generate IME results.
   // Any IME results generated by a unfiltered key down event must be sent
   // before the key down event, to avoid some tricky issues. For example,
   // when using latin-post input method, pressing 'a' then Backspace, may
@@ skipping 169 matching lines @@
   // If IME has filtered this event, then replace virtual key code with
   // VK_PROCESSKEY. See comment in ProcessKeyEvent() for details.
   // It's only required for keydown events.
   // To emulate windows behavior, when input method is enabled, if the commit
   // text can be emulated by a Char event, then don't do this replacement.
   if (!NeedCommitByForwardingCharEvent()) {
     wke->windowsKeyCode = kCompositionEventKeyCode;
     // keyidentifier must be updated accordingly, otherwise this key event may
     // still be processed by webkit.
     wke->setKeyIdentifierFromWindowsKeyCode();
-    // Prevent RenderView::UnhandledKeyboardEvent() from processing it.
-    // Otherwise unexpected result may occur. For example if it's a
-    // Backspace key event, the browser may go back to previous page.
-    wke->skip_in_browser = true;
   }
   host_view_->ForwardKeyboardEvent(*wke);
 }
 
 void GtkIMContextWrapper::ProcessUnfilteredKeyPressEvent(
     NativeWebKeyboardEvent* wke) {
   // Send keydown event as it, because it's not filtered by IME.
   host_view_->ForwardKeyboardEvent(*wke);
 
   // IME is disabled by WebKit or the GtkIMContext object cannot handle
@@ skipping 284 matching lines @@
     } while (pango_attr_iterator_next(iter));
     pango_attr_iterator_destroy(iter);
   }
 
   // Use a black thin underline by default.
   if (underlines->empty()) {
     underlines->push_back(
         WebKit::WebCompositionUnderline(0, length, SK_ColorBLACK, false));
   }
 }